-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HOCON #5989
Add support for HOCON #5989
Conversation
Oh yes, they most definitely are (if files are not loaded by the UI in the diff you know it's almost certainly too big 😉), and they're mostly filled with comments which are completely ignored so are adding unnecessary bloat. |
I've switched them out for some (significantly 🙂 ) shorter ones, the first has fair few comments, I can remove them if you like. I think a sample like https://github.com/emqx/hocon/blob/master/sample-configs/test01.conf would be a better overall showcase of the syntax, though I think I saw somewhere that you prefer real world examples? |
Sure, but there be dragons. This is going to be fraught with troubles as this is an incredibly popular extension and getting a performant heuristic for what is effectively a variant of JSON is going to be a nightmare. It's better to leave it for now and peeps can use an override.
Yup. We want real world usage, not illustrations of usage. The samples here should be go on for now, especially as this is a unique extension. |
Cheers!
In that case I'll take your advice, I see |
Description
Hi, this PR adds support for hocon files with the
.hocon
file extension. Also prevalently used with hocon files is the.conf
extension, though adding this would bring in a lot of false positives, so I'd like to maybe do a follow up PR for that if that's ok 😅 . Also let me know if the sample files are too large, thanks.Checklist: