-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language Just / Justfile #6086
Add language Just / Justfile #6086
Conversation
I'm the maintainer of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
We also need the cached license file from the grammar which should have been downloaded when you ran script/add-grammar
. If you can't find it or it wasn't for some reason, you can get it again by running: bundle exec licensed cache -c vendor/licenses/config.yml
.
Co-authored-by: Casey Rodarmor <[email protected]>
Co-authored-by: Casey Rodarmor <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename the samples/Justfile/
directory which contains your sample to samples/just/
You'll also need to run list-grammars again and correct the ordering to resolve the last of the test failures.
Hey @lildude, thank you for your support in getting this PR merged. 👍 Up: I reread the CONTRIBUTING.md, I guess that answers it! 😅:
|
Description
This PR adds language support for
just
.Checklist: