Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DialURL supports options to configure net.Dialer and tls.Config #249

Merged
merged 1 commit into from
Dec 10, 2019
Merged

DialURL supports options to configure net.Dialer and tls.Config #249

merged 1 commit into from
Dec 10, 2019

Conversation

regeda
Copy link
Contributor

@regeda regeda commented Nov 28, 2019

No description provided.

@regeda
Copy link
Contributor Author

regeda commented Nov 28, 2019

The PR #209 might be closed after merge.

@stefanmcshane
Copy link
Contributor

@regeda - As this is suggesting future deprecation of a feature, commits should be made in the v3 folder for Go Modules going forward.
The top level code only exists whilst we figure out the best way to maintain backwards compatibility before Go Modules.
TL:DR; please make changes to v3/ and I’ll review this weekend.

@stefanmcshane
Copy link
Contributor

As we were on v3 prior to Go Modules, updating a top level go.mod would have been considered a breaking change for backwards compatibility as outlined in #247.
If you can get it working in such a way that does not break any old versions, we would be more than happy to review!
#246 for reference also

@regeda
Copy link
Contributor Author

regeda commented Dec 2, 2019

@stefanmcshane I have updated the code after your comments. Could you look at that?

@regeda
Copy link
Contributor Author

regeda commented Dec 9, 2019

@johnweldon Could you review the PR? Looks like it stucks.

johnweldon
johnweldon approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@johnweldon johnweldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for this PR

@johnweldon johnweldon merged commit 2517798 into go-ldap:master Dec 10, 2019
@regeda regeda deleted the dial-with-opts branch December 10, 2019 17:42
@botastic
Copy link

Hey will there be a new realese / tag for this so I can get it without using the commit hash? :)

@regeda regeda mentioned this pull request Dec 11, 2019
Closed
@johnweldon
Copy link
Member

Hey will there be a new realese / tag for this so I can get it without using the commit hash? :)

v3.1.4

@botastic
Copy link

Thank you very much

@stefanmcshane stefanmcshane mentioned this pull request Jan 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnweldon johnweldon johnweldon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@regeda @stefanmcshane @botastic @johnweldon