Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more og:site_name when building under Hugo 0.112.x #1531

Closed
Tracked by #1510
chalin opened this issue Jun 2, 2023 · 1 comment · Fixed by #1534
Closed
Tracked by #1510

No more og:site_name when building under Hugo 0.112.x #1531

chalin opened this issue Jun 2, 2023 · 1 comment · Fixed by #1534
Labels
CI/infra CI & infrastructure dependencies Pull requests that update a dependency file

Comments

@chalin
Copy link
Collaborator

chalin commented Jun 2, 2023

Beware that when building with 0.112.3, we lose og:site_name:

-- a/404.html
+++ b/404.html
@@ -3,7 +3,7 @@
   <head>
     <meta charset="utf-8">
 <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
-<meta name="generator" content="Hugo 0.110.0">
+<meta name="generator" content="Hugo 0.112.3">
 <meta name="robots" content="noindex, nofollow">
 
 
@@ -23,7 +23,7 @@
 <meta property="og:title" content="404 Page not found" />
 <meta property="og:description" content="Docsy does docs" />
 <meta property="og:type" content="website" />
-<meta property="og:url" content="/404.html" /><meta property="og:site_name" content="Docsy" />
+<meta property="og:url" content="/404.html" />
 <meta itemprop="name" content="404 Page not found">
 <meta itemprop="description" content="Docsy does docs"><meta name="twitter:card" content="summary"/>
 <meta name="twitter:title" content="404 Page not found"/>
diff --git a/about/index.html b/about/index.html
index bbd685d..b0c6445 100644

We'll have to investigate this carefully. It's not clear to me whether this is a Hugo "bug" or a sign that our config needs to be updated.
@chalin chalin added dependencies Pull requests that update a dependency file CI/infra CI & infrastructure labels Jun 2, 2023
@chalin chalin changed the title Upgrade Hugo to 0.112.x Upgrade Hugo to 0.112.x or later Jun 2, 2023
@chalin chalin mentioned this issue Jun 2, 2023
Open
14 tasks
deining added a commit to deining/docsy that referenced this issue Jun 2, 2023
@deining
Upgrade Hugo to 0.112.7 (google#1531)
bb46cd6
@deining deining mentioned this issue Jun 2, 2023
Merged
@deining
Copy link
Collaborator

deining commented Jun 2, 2023

We'll have to investigate this carefully. It's not clear to me whether this is a Hugo "bug" or a sign that our config needs to be updated.

Nice catch! The latter is the case, our config needs to be updated. This is done in #1534.

deining added a commit to deining/docsy that referenced this issue Jun 2, 2023
@deining
Upgrade Hugo to 0.112.3 (google#1531)
e538970
chalin pushed a commit to deining/docsy that referenced this issue Jun 5, 2023
@deining @chalin
Upgrade Hugo to 0.112.3 (google#1531)
8665490
@chalin chalin changed the title Upgrade Hugo to 0.112.x or later No more og:site_name when building under Hugo 0.112.x Jun 5, 2023
This was referenced Jun 5, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI/infra CI & infrastructure dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Hugo to 0.112.3 and fix en title deining/docsy
2 participants
@chalin @deining