-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right hand TOC sidebar not using full screen height #827
Comments
Oh well spotted! Not sure how that happened... |
Actually I think I do know how it happened - we initially didn't have nearly as many additional repo and print options at the top, now that they're there they take up a lot of sidebar real estate. One thing I have noticed in your preview is that using the full height does make it look quite different on long pages with a lot of headings (but maybe that's not a bad thing?) Anyone else have thoughts? @narrenfrei? |
It does look different, but I feel that it now looks correct IMHO. |
@LisaFC - the fix LGTM. Shall I merge or do you want to do it? |
Merge away! |
Co-authored-by: Patrice Chalin <[email protected]>
As you can see in this screen grab (of the bottom right corner of the screen) the right hand TOC sidebar is not using all the available screen when not scrolled to the bottom, so the vertical divider is short of the bottom.
If you scroll all the way down it is fine as the footer takes up the space.
Will raise a PR for the fix.
The text was updated successfully, but these errors were encountered: