Avoid tabbed-pane.scss style leakage #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
commented
Aug 15, 2022
Comment on lines
+1
to
4
| .tab-content { | ||
| .highlight { | ||
| margin: 0rem 0 2rem 0; | ||
| } |
There was a problem hiding this comment.
@deining may have a better take on it - I'll take a look, but my immediate thought is possibly we might want a style for highlight content that's in a tabbed pane but not inside a code block. Though if they're the same style settings....
There was a problem hiding this comment.
Though hmm, we only apply highlight to code blocks, so that doesn't make sense.
There was a problem hiding this comment.
This fixes the style "leakage". Can you approve it as is @LisaFC?
We can address the possible style "dead code" separately.
There was a problem hiding this comment.
We'll track this via:
4 tasks
chalin
force-pushed
the
chalin-im-fix-tabpane-style-leakage-2022-08-15
branch
from
a7047ca to
0bc7ff9
Compare
LisaFC
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies minimal style changes in order to address the
highlightstyle override reported in:Preview: https://deploy-preview-1157--docsydocs.netlify.app/docs/adding-content/shortcodes/#tabbed-panes
Screenshots
Note the equal amount of spacing before and after the code block in the After screenshot.