Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make docsy point to latest version of dependencies #1418

Closed
wants to merge 0 commits into from
Closed

Make docsy point to latest version of dependencies #1418

wants to merge 0 commits into from

Conversation

deining
Copy link
Collaborator

@deining deining commented Feb 15, 2023 •
edited
Loading

This PR is related to #1409. It ensures that we use and test docsy (module setup) with latest version of dependencies.

@deining deining added the module label Feb 15, 2023
@deining deining requested a review from chalin February 15, 2023 07:06
chalin
chalin reviewed Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deining: is it still relevant to merge this? If so, does it need updating first?

@chalin chalin added this to the 23Q2 milestone Jun 1, 2023
@deining
Copy link
Collaborator Author

deining commented Jun 1, 2023

Hi @deining: is it still relevant to merge this?

Yes.

If so, does it need updating first?

Yes, since Font-Awesome is at 6.4.0 meanwhile.

The correct order of tasks would be:

@deining deining requested a review from chalin June 1, 2023 15:05
@chalin
Copy link
Collaborator

chalin commented Jun 1, 2023

Thanks for the guidance @deining, it's much appreciated as I context switch between projects.
#1529 has been merged.

@chalin
Copy link
Collaborator

chalin commented Jun 2, 2023

@deining - looking forward to this update so that we can proceed with the release of 0.7.0. Thanks! /cc @geriom

@deining deining closed this Jun 2, 2023
@deining
Copy link
Collaborator Author

deining commented Jun 2, 2023 •
edited
Loading

@deining - looking forward to this update so that we can proceed with the release of 0.7.0. Thanks! /cc @geriom

I inadvertently closed this issue and I don't have sufficient rights to reopen it. Authored new PR #1533 instead.

@chalin
Copy link
Collaborator

chalin commented Jun 5, 2023

Strange that you wouldn't have the rights to reopen your own PR. Thanks for #1533.

@chalin chalin mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin Awaiting requested review from chalin

Assignees
No one assigned
Labels
module
Projects
None yet
Milestone
23Q2
Development

Successfully merging this pull request may close these issues.
2 participants
@deining @chalin