[BSv5] Refactor Click-to-copy #1447
Conversation
geriom
force-pushed
the
reactivate-click-to-copy
branch
from
c67788e to
9f7511b
Compare
geriom
force-pushed
the
reactivate-click-to-copy
branch
from
9f7511b to
aa7bb07
Compare
assets/scss/_code.scss
Outdated
| @@ -1,101 +1,84 @@ | |||
| // Code formatting. | |||
|
|
|||
| .td-content { | |||
| // Highlighted code. | |||
There was a problem hiding this comment.
It's hard to follow what has changed in this file. Could you consider not reformatting it in this PR so that the diffs are more clearly seen?
Did you only change the lines for the c2c button?
There was a problem hiding this comment.
There's nothing new in this file. I deleted all the styles for the tooltip and prettified it.
assets/scss/_code.scss
Outdated
| transition: visibility 0s, opacity 0.5s linear; | ||
| } | ||
| // click-to-copy button | ||
| button { |
There was a problem hiding this comment.
I'd prefer that you use a class name specific to this feature (and add the class via the js):
| button { | |
| button.td-click-to-copy { |
There was a problem hiding this comment.
Updated here and added the class in the js file
| @@ -148,6 +148,24 @@ guessSyntax: true | |||
| {{< /tab >}} | |||
| {{< /tabpane >}} | |||
|
|
|||
| If you are using a Docsy version later than `0.6.0`, the code blocks show a | |||
There was a problem hiding this comment.
| If you are using a Docsy version later than `0.6.0`, the code blocks show a | |
| If you are using a Docsy version `0.6.0` or later, code blocks show a |
There was a problem hiding this comment.
This does not work for 0.6.0 and we haven't definitely decided on the next version number. I think "later than" covers that. About the article "the", although I know I don't really need it here, I try to never omit it based on this guideline: https://developers.google.com/style/articles
|
I've merged #1454. Apologies for the resulting merge conflicts, but as I mention in the PR, I should have done this earlier. |
|
@geriom - a more general question, why not use clipboardjs.com? |
geriom
force-pushed
the
reactivate-click-to-copy
branch
from
aa7bb07 to
3692428
Compare
I don't think we need an additional dependency for a straightforward feature. I can see how that library would be very helpful for single-page applications with lots of dynamic content, but here I don't see a big benefit. |
Refactor of PR google#1245. Bootstrap5-compatible code.
chalin
force-pushed
the
reactivate-click-to-copy
branch
from
3692428 to
134127d
Compare
chalin
changed the title
Refactor of PR #1245. Bootstrap5-compatible code.
Closes #1267