-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the custom search input partial #1512
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
e55ea7b
to
e48d3b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- See inline comment.
- Also, this new feature should be mentioned in the docs.
e48d3b7
to
4b4210e
Compare
4b4210e
to
a0df1b8
Compare
I recently raised #2194 which is related. I think I would prefer if there was a guard for the custom search implementation instead of relying on the presence of It will also help downstream users to use the same parameter as a check while implementing other stuff in other layouts. Moreover, as mentioned in the issue, I would prefer to also override the search script in We can include the script in our |
This PR exposes a template (empty by default) for customizing the search input, which will be included if all existing search options were disabled.
The purpose of this PR is that avoid overriding the
layouts/partials/search-input.html
which will make other search options unusable and hard to maintain on users/clients side.