Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BS5.3] Replace .navbar-dark by data attribute and other style adjustments #1896

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Mar 14, 2024

  • Contributes to Upgrade to Bootstrap 5.3 #1528
  • Replaces .navbar-dark by data-bs-theme="dark" data attribute
  • Adjusts search element styles to work with the new navbar's dark mode and in the left-nav too (not in dark mode)

Preview: https://deploy-preview-1896--docsydocs.netlify.app/docs/

Screenshots

Light mode (default):

image
image

Dark mode:

image
image

@chalin chalin changed the title [BS5.3] Replace . navbar-dark by data attribute [BS5.3] Replace .navbar-dark by data attribute Mar 14, 2024
@chalin chalin mentioned this pull request Mar 14, 2024
4 tasks
@chalin chalin force-pushed the chalin-im-navbar-dark-2024-03-14 branch from af911fb to 680cca8 Compare March 14, 2024 23:23
@chalin chalin changed the title [BS5.3] Replace .navbar-dark by data attribute [BS5.3] Replace .navbar-dark by data attribute and other style adjustments Mar 14, 2024
@chalin chalin force-pushed the chalin-im-navbar-dark-2024-03-14 branch from 680cca8 to cdd40f4 Compare March 15, 2024 19:51
@fekete-robert
Copy link
Collaborator

fekete-robert commented Mar 16, 2024

When using a dark system theme under firefox the text in the navbar search is dark (tested on mac and linux):

Screenshot from 2024-03-16 09-36-39

Using Brave (a chrome derivative) it's fine on both systems.

But this is probably an edge case, since firefox has a marginal market share, so we can consider it a known issue and go forward.

@chalin
Copy link
Collaborator Author

chalin commented Mar 26, 2024

Thanks for that careful cross-browser check. Let's track that issue via:

@chalin chalin merged commit b077a74 into google:main Mar 26, 2024
11 checks passed
@chalin chalin deleted the chalin-im-navbar-dark-2024-03-14 branch March 26, 2024 22:03
@chalin chalin mentioned this pull request Mar 28, 2024
26 tasks
@chalin chalin added this to the 24Q1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants