-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UG] Explain how to enable the light/dark-mode menu #1914
[UG] Explain how to enable the light/dark-mode menu #1914
Conversation
6c8abb5
to
c04c876
Compare
c04c876
to
0e09609
Compare
a6693a0
to
4c8891e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good to me.
Added a few comments addressing minor issues.
### Light/Dark mode menu | ||
|
||
To enable the display of a Light-/[Dark-mode] menu in the navbar, set | ||
`params.ui.showLightDarkModeMenu` to true in your project's configuration file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
params.ui.showLightDarkModeMenu
:
In the section Code highlighting with Prism
above, we put a tabbed pane in place, showing toml
, yaml
and json
variants. For the sake of consistency, I would propose to implement the same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LisaFC et al.: we need to discuss this in the next PSC. I find that for simple boolean params, it isn't worth overhead. If we had something setup like what they have for the Hugo docs, it would make it slightly more bearable! Anyhow, I've made the addition this time.
4c8891e
to
358f3c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now!
Preview: https://deploy-preview-1914--docsydocs.netlify.app/docs/adding-content/lookandfeel/#navbar