Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark-mode] Tabbed panes fix #1920

Merged

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Apr 6, 2024

  • Contributes to Support dark mode #331
  • Adjusts tab-pane tab styles so as to be compatible with light & dark modes

Preview: https://deploy-preview-1920--docsydocs.netlify.app/docs/adding-content/shortcodes/#tabbed-panes

Screenshots

Before (dark mode)

image

After (dark mode)

image

Before (light mode)

image

After (dark mode) -- same as before

image

@chalin chalin added this to the 24Q2 milestone Apr 6, 2024
@chalin chalin mentioned this pull request Apr 6, 2024
26 tasks
@chalin chalin force-pushed the chalin-im-dark-mode-tabbed-panes-2024-04-06 branch from 9330c8e to c4e20bf Compare April 6, 2024 23:35
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin force-pushed the chalin-im-dark-mode-tabbed-panes-2024-04-06 branch from c4e20bf to ec0d4d8 Compare April 7, 2024 21:04
@chalin chalin merged commit 74404af into google:main Apr 7, 2024
11 checks passed
@chalin chalin deleted the chalin-im-dark-mode-tabbed-panes-2024-04-06 branch April 7, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants