Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add feedback_* to i18n/ja.toml #2149

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

rinsuki
Copy link
Contributor

@rinsuki rinsuki commented Dec 22, 2024

Context: while reading OpenTelemetry's document, I noticed that their feedback form's i18n is completely broken in Japanese:

image

(Screenshot of https://opentelemetry.io/ja/docs/ )

and after some research, I think it was from docsy, not opentelemetry.io's fault, then I just made this patch.

Copy link

google-cla bot commented Dec 22, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chalin chalin force-pushed the i18n/ja/feedback_strings branch from 7efa316 to 9db919f Compare January 3, 2025 22:05
@chalin
Copy link
Collaborator

chalin commented Jan 3, 2025

Thank you @rinsuki, I've asked https://github.com/orgs/open-telemetry/teams/docs-ja-maintainers to review and comment.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will give OTel docs-ja-maintainers some time to give feedback.

@@ -77,3 +77,13 @@ other = "If you want to get more involved by contributing to {{ .Site.Title }},
other = "You can find out how to contribute to {{ .Site.Title }} in our"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized that there are some more untranslated lines/strings in this file:

https://github.com/google/docsy/blob/fa81a86be8bf130d94a43b8898c6716819fdae87/i18n/ja.toml#L63C1-L79C34

@rinsuki: are you able to translate these lines as well? Your help is appreciated!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically I can directly translate word-by-word, but I think it wouldn't be a good translate (If I do that, japanese speakers (like me) feels it is translated from other language rather than written by native), but I don't have a idea to good paraphrase for its text right now.

by the way, community_how_to assume text ends with community_guideline:

<p>
{{ T "community_how_to" . }}
<a href="{{ $contribUrl | relURL }}">{{ T "community_guideline" }}</a>.
</p>

but some languages wants to have additional text after link, it would be good to have something like community_how_to_suffix.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks @rinsuki. I'll merge this as an increment, and we can address the other fields as necessary. Thanks for pointing that out @deining.

@ymotongpoo
Copy link

@chalin Do you need Japanese speakers review? (it seems https://github.com/orgs/open-telemetry/teams/docs-ja-maintainers consists of non-Japanese speakers. Asking just in case.)

If yes, the content looks good to me. (btw, https://github.com/orgs/open-telemetry/teams/docs-ja-approvers is docs-ja-maintainers + me and @katzchang)

@chalin
Copy link
Collaborator

chalin commented Jan 4, 2025

@chalin Do you need Japanese speakers review? (it seems https://github.com/orgs/open-telemetry/teams/docs-ja-maintainers consists of non-Japanese speakers. Asking just in case.)

Oh! Yes, that was my intention.

If yes, the content looks good to me.

Thank you for validating.

(btw, https://github.com/orgs/open-telemetry/teams/docs-ja-approvers is docs-ja-maintainers + me and @katzchang)

Got it, thanks.

@chalin chalin merged commit 2f361b2 into google:main Jan 4, 2025
11 checks passed
@chalin chalin added this to the 25Q1 milestone Jan 9, 2025
marshalc pushed a commit to ouhft/docsy that referenced this pull request Jan 30, 2025
commit 77da7e4
Author: Patrice Chalin <[email protected]>
Date:   Thu Jan 30 06:08:47 2025 -0500

    Fix language-drop style when in left nav (google#2183)

commit a854cb3
Author: Patrice Chalin <[email protected]>
Date:   Thu Jan 23 20:21:54 2025 -0500

    Update Hugo to 0.142.0, and more (google#2182)

commit 7b3eaa4
Author: Andreas Deininger <[email protected]>
Date:   Tue Jan 21 21:28:01 2025 +0100

    Remove docsy's custom shortcode 'figure' (google#2175)

commit 258d3e5
Author: Patrice Chalin <[email protected]>
Date:   Tue Jan 21 14:48:14 2025 -0500

    Drop style attribute using undef CSS var (google#2180)

commit ef59ee7
Author: Patrice Chalin <[email protected]>
Date:   Mon Jan 20 17:47:51 2025 -0500

    [CI] Upgrade NPM packages (google#2179)

commit 9c41490
Author: Andreas Deininger <[email protected]>
Date:   Mon Jan 20 23:29:41 2025 +0100

    Fix error when building user guide with latest hugo version 0.141.0 (google#2177)

commit e6d9477
Author: Patrice Chalin <[email protected]>
Date:   Fri Jan 10 11:30:19 2025 -0500

    Breadcrumb for blog pages, and per-page/section config (google#2161)

commit 9fbb3a6
Author: Andreas Deininger <[email protected]>
Date:   Thu Jan 9 22:10:40 2025 +0100

    Bump KaTeX to latest version (google#2168)

commit a9ea2b7
Author: Peter Dave Hello <[email protected]>
Date:   Fri Jan 10 00:51:45 2025 +0800

    Update and improve zh-TW Traditional Chinese locale (google#2158)

    Co-authored-by: ChengHao Yang <[email protected]>

commit 1b3fc5a
Author: Patrice Chalin <[email protected]>
Date:   Thu Jan 9 08:47:53 2025 -0500

    Userguide config cleanup, drop pygments config (google#2166)

commit 88ec5ae
Author: Patrice Chalin <[email protected]>
Date:   Thu Jan 9 08:40:44 2025 -0500

    Render-heading: process class attributes (google#2165)

commit dd5e69b
Author: Patrice Chalin <[email protected]>
Date:   Wed Jan 8 12:46:18 2025 -0500

    Hide index-page single breadcrumb (google#2160)

commit 30a6c34
Author: Patrice Chalin <[email protected]>
Date:   Wed Jan 8 12:18:17 2025 -0500

    Blog list layout whitespace cleanup (google#2159)

commit 3aa3dc7
Author: Patrice Chalin <[email protected]>
Date:   Wed Jan 8 11:49:09 2025 -0500

    Blog list layout: display the page title and content (google#2157)

commit 6c22754
Author: Patrice Chalin <[email protected]>
Date:   Tue Jan 7 17:04:11 2025 -0500

    Blog list layout refactoring (google#2155)

commit 95a08e1
Author: Patrice Chalin <[email protected]>
Date:   Tue Jan 7 12:49:26 2025 -0500

    [CI] Upgrade NPM pkgs, Hugo to 0.140.2 (google#2154)

commit 2f361b2
Author: rinsuki <[email protected]>
Date:   Sun Jan 5 02:09:10 2025 +0900

    i18n: Add feedback_* to i18n/ja.toml (google#2149)

commit fa81a86
Author: Andreas Deininger <[email protected]>
Date:   Fri Jan 3 22:59:17 2025 +0100

    Bump dependency Font-Awesome to latest version 6.7.2 (google#2151)

commit 67f6b6a
Author: Patrice Chalin <[email protected]>
Date:   Thu Dec 12 13:27:01 2024 -0500

    Blog 2024 review: Add link to LFX mentorships (google#2147)

commit f3e6ca9
Author: Patrice Chalin <[email protected]>
Date:   Thu Dec 12 12:41:08 2024 -0500

    Blog 2024 year in review (google#2145)

commit 99c2842
Author: Patrice Chalin <[email protected]>
Date:   Thu Dec 12 10:05:14 2024 -0500

    [CI] Upgrade NPM pkgs, Hugo to 0.139.4 (google#2143)

commit dd72a27
Author: Patrice Chalin <[email protected]>
Date:   Sat Nov 23 06:34:07 2024 -0500

    [CI] Patch search page HTML until Hugo is fixed, FA upgrade (google#2135)

commit fed2d28
Author: Patrice Chalin <[email protected]>
Date:   Wed Nov 20 06:09:53 2024 -0500

    Upgrade Hugo and FontAwesome (google#2129)

commit 97dadaa
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 19 18:48:09 2024 -0500

    [CI] Handle creation of empty Hugo-modules for deps (google#2128)

commit 2a6ecfc
Author: Patrice Chalin <[email protected]>
Date:   Tue Nov 19 17:33:23 2024 -0500

    Update CHANGELOG.md: fix copy-paste error (google#2127)

commit 706e23c
Author: Shihyu <[email protected]>
Date:   Sat Nov 16 23:29:23 2024 +0800

    Fix typo in deployment documentation (google#2123)

commit aedef51
Author: Patrice Chalin <[email protected]>
Date:   Fri Nov 15 11:47:52 2024 -0500

    Upgrade Hugo and merge optional deps into dev (google#2125)

commit d1e6470
Author: Patrice Chalin <[email protected]>
Date:   Fri Nov 15 11:29:18 2024 -0500

    [CI] Restore format check as a part of `npm test` (google#2124)

commit 6e42d49
Author: Patrice Chalin <[email protected]>
Date:   Fri Nov 15 11:19:51 2024 -0500

    External link checking + project pages (google#2120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants