Remove markdownify for non-Markdown files #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using Asciidoc (or RST, I suppose), the Inner content passed to these shortcodes should already be HTML-formatted. Making this change allows us to pass formatted content (which may include a shortcode) to a shortcode, which previously only worked with Markdown.
|
This looks very useful, thanks! We may tweak how we use markdownify in some of our shortcodes/layouts in future (we had to come up with a quick solution last year that worked with Hugo both before and after 0.6.0), but this is great for now. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Asciidoc (or RST, I suppose), the Inner content passed to these shortcodes should already be HTML-formatted. Making this change allows us to pass formatted content (which may include a shortcode) to a shortcode, which previously only worked with Markdown.
There might be an opportunity for a new abstraction here (maybe a partial?), but this approach seems to work OK for me. Maybe it'll be useful to others too?