-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Bootstrap v5: initial work #517
Conversation
Oh, that's good that it's a simple fix! I'll try making the change to a site running on Netlify with the latest Bootstrap and Hugo versions and see what happens. |
Even easier: have a look at the netlify deploy associated with this PR. Overall it looks pretty good, but a few quirks need to be fixed:
|
Ah yes, of course! And ooh yes, it seems like it's doing something very odd to some of our fonts and alignment. I'll play around with it and see what's happening in the generated HTML etc. Definitely won't move to v5 until we can come up with something that works with it and doesn't break formatting with v4. |
I fully understand and agree with this decision.
Looking forward to your findings! Good luck! |
@geriom can you figure out how/if you fixed this in Tekton? |
73228e9
to
8436f96
Compare
I've rebased and upgraded BS to v5.2.0. I'll then progressively work my way through the migration document and commit sectional changes as I go. |
4aacb83
to
2dec6b9
Compare
cd61ee6
to
c309d3a
Compare
Great. I just bumped BS to latest version v5.2.3 and Font-Awesome to version 6.2.1. |
As agreed out-of-band, I'll be merging this initial work. |
* Update to bootstrap v5: initial work * Utilities: rename .ml-* and .mr-* to .ms-* and .me-* * Bump bootstrap to latest version 5.2.3 (npm + module) Co-authored-by: Patrice Chalin
With official release bootstrap 5 coming soon, I just had a look at #470 to overcome the compatibility issues mentioned there.
It turned out to be quite easy, there was only one thing I had to fix as mentioned in the migration guide:
color-yiq() function and related variables are renamed to color-contrast()
With this PR applied, hugo runs with bootstrap 5. You may have a look at the netlify deploy associated with this PR.
I thought I share this already, though we should wait with the merge until bootstrap 5 is officially released. Maybe it is of help for others that want to play around with bootstrap 5 beta version already.
Preview: https://deploy-preview-517--docsydocs.netlify.app/
Contributes to: