blocks/feature reworked to support use from .md files #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
commented
Oct 16, 2021
| </div> | ||
| <h4 class="h3"> | ||
| {{- .Get "title" | markdownify -}} |
There was a problem hiding this comment.
Reverting to the code used prior to #526 here.
chalin
force-pushed
the
chalin-blocks-feature-2021-10-15
branch
from
7108faf to
e69f182
Compare
chalin
force-pushed
the
chalin-blocks-feature-2021-10-15
branch
from
e69f182 to
efea297
Compare
chalin
commented
Oct 16, 2021
| <h4 class="h3"> | ||
| {{- .Get "title" | markdownify -}} | ||
| </h4> | ||
| <div class="mb-0"> |
There was a problem hiding this comment.
I kept the mb-0 class for now even though in some cases it isn't useful -- #724 (comment). I might have an alternative to suggest in a followup PR.
7 tasks
|
This is great, thanks! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<p>to a<div>to avoid the invalid<p>nesting -- feature shortcode no longer works inside of markdown files #724 (comment). This might affect styling, but that can (should?) be handled separately./cc @nate-double-u @celestehorgan