-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plantuml svg loader #800
Plantuml svg loader #800
Conversation
Ooh, this looks very helpful. Do you want to also add some instructions to https://www.docsy.dev/docs/adding-content/diagrams-and-formulae/#uml-diagrams-with-plantuml so users will know how to enable this feature? |
@LisaFC: A small line perhaps, but is this enough, or would you prefer a more extensive writeup about this? |
No, that's perfect! I'm sure someone will let us know if they want more information. |
I just realized that this PR sets submodule |
No, this was not intended! Did I merge the main branch incorrectly? I don't see anything related to bootstrap in the changed files? |
This PR gives the possibility to use an SVG loader instead of an using an img tag when using PlantUML. The reason for this is that the image tag does not support links or other responsive actions in the generated UML diagram.
By default, nothing changes. If you want this PR to be enabled, you'll need to change the configuration like this
Setting the params.plantuml.svg property to true will add an additional JavaScript file (svg-loader.min.js), and will write svg tags instead of img tags.