-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify setup: install Hugo automatically (and get the right version) using NPM #841
Simplify setup: install Hugo automatically (and get the right version) using NPM #841
Conversation
I believe that we had to make an explicit call to `npm install` before, because the project wasn't using any NPM packages. We are now, so this removed the (now) redundant `npm install` command.
glorious! I like the idea of making the default easy :) I don't have Netlify privileges (I don't think ...) though |
Thanks for the feedback @emckean. We can merge this w/o the cache-clearing test. Can I go ahead and merge? |
Just to be clear: if ever there's an issue with the cache, it won't have to do with the |
I'm going to take @emckean's "glorious" comment as an approval and merge this. :) |
This is great, thanks! Let me know if there's anything I need to do with my Netlify privileges, but it doesn't look like it as the production build is working. |
Hmm, I just realized that the README in this project doesn't describe how to build docsy and the user guide. We should change that: let's discuss this in #846. |
This PR introduces the use of the hugo-extended package, a "Plug-and-play binary wrapper for Hugo Extended".
By doing so we reduce the burden on contributors: the right version and variant (extended edition), gets fetched automatically when
npm install
is run. Also, from now on, every version of the website will be associated to the version of Hugo needed to build it, and npm will fetch the proper version on an install.@LisaFC @emckean et all - WDYT? If you agree with this change, I'll make followup PRs to update the README, etc.