Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented and Tested Hash, HashSequenceStart, SequenceUpdate, and SequenceComplete #284

Merged
merged 15 commits into from
Jun 22, 2022

Conversation

matt-tsai
Copy link
Contributor

Wrote implemented and wrote tests for the following functions: Hash, HashSequenceStart, SequenceUpdate, and SequenceComplete.

@matt-tsai matt-tsai requested a review from a team as a code owner June 10, 2022 22:02
Copy link
Member

@chrisfenner chrisfenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a couple super minor nits but ready to merge when fixed!

@alexmwu alexmwu merged commit 3b95eba into google:tpmdirect Jun 22, 2022
@alexmwu
Copy link
Contributor

alexmwu commented Jun 22, 2022

Double checked Chris's comments were addressed, thanks for this!

@matt-tsai matt-tsai deleted the HashAndSequence branch June 22, 2022 00:46
@matt-tsai matt-tsai changed the title Implemented Hash, HashSequenceStart, SequenceUpdate, and SequenceComplete Implemented and Tested Hash, HashSequenceStart, SequenceUpdate, and SequenceComplete Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants