support go generate for constants #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the definition of types in constants.go into that file, so that tools such as stringer can be pointed at it without also being pointed at structures.go. The TPM specification defines several duplicate constants (AlgSHA = AlgSHA1, for example). This change moves all the "duplicated, extra" definitions into a new file called constants_internal.go so they can easily be omitted from tools such as stringer. This change moves the definition of TPMRC helper constants so that they are not themselves TPMRC values. This prevents tools such as stringer from generating String() methods for them. Finally, this change adds TPMHT (Handle type) values for completeness and fixes some minor typos in initialisms (TPMHTPCR, TPMHTAC). See https://github.com/golang/go/wiki/CodeReviewComments#initialisms The 'go generate' command has been added at the top of constants.go, so 'go generate' from the command line will generate a file that implements Stringer for all these types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the definition of types in constants.go into that file, so that tools such as stringer can be pointed at it without also being pointed at structures.go.
The TPM specification defines several duplicate constants (AlgSHA = AlgSHA1, for example). This change moves all the "duplicated, extra" definitions into a new file called constants_internal.go so they can easily be omitted from tools such as stringer.
This change moves the definition of TPMRC helper constants so that they are not themselves TPMRC values. This prevents tools such as stringer from generating String() methods for them.
Finally, this change adds TPMHT (Handle type) values for completeness and fixes some minor typos in initialisms (TPMHTPCR, TPMHTAC). See https://github.com/golang/go/wiki/CodeReviewComments#initialisms
The 'go generate' command has been added at the top of constants.go, so 'go generate' from the command line will generate a file that implements Stringer for all these types