-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log transaction durations #2682
base: master
Are you sure you want to change the base?
Conversation
d0205d9
to
1f796e1
Compare
1f796e1
to
6479cf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
core/src/main/java/google/registry/persistence/transaction/JpaTransactionManagerImpl.java
line 279 at r1 (raw file):
T result = work.call(); txn.commit(); logger.atInfo().log(
Consider throttling using logger's atMostEvery
method or filter out very short transactions.
Code quote:
logger.atInfo().log(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @weiminyu)
core/src/main/java/google/registry/persistence/transaction/JpaTransactionManagerImpl.java
line 279 at r1 (raw file):
Previously, weiminyu (Weimin Yu) wrote…
Consider throttling using logger's
atMostEvery
method or filter out very short transactions.
yeah, maybe we can filter out ones less than.....100ms?
6479cf2
to
7f29718
Compare
7f29718
to
b8902ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
b8902ef
to
b63d106
Compare
b63d106
to
f4eda41
Compare
There can be delays in releasing predicate locks when we have transactions that are long-lived -- even delays in releasing predicate locks acquired by shorter-lived transactions. Logging the transaction duration will allow us to get a sense as to transaction durations during busy times.
f4eda41
to
98a027b
Compare
There can be delays in releasing predicate locks when we have transactions that are long-lived -- even delays in releasing predicate locks acquired by shorter-lived transactions. Logging the transaction duration will allow us to get a sense as to transaction durations during busy times.
This change is