feat(tests): [Bigtable] add conformance tests and proxy #7959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
added
the
do not merge
bshaffer
removed
the
do not merge
meeral-k
approved these changes
Jan 24, 2025
mutianf
approved these changes
Jan 24, 2025
| _Retry_WithRetryInfo | ||
| TestMutateRows_Generic_DeadlineExceeded | ||
| TestReadRow_Generic_DeadlineExceeded | ||
| TestReadRows_NoRetry_OutOfOrderError |
There was a problem hiding this comment.
Can we remove TestReadRows_NoRetry_OutOfOrderError, TestReadRows_Retry_StreamReset, TestReadRows_Retry_PausedScan and TestReadRows_Retry_LastScannedRow from this list? So we don't forget about them :) We don't have to mark conformance test passing as a required step for presubmit for now.
There was a problem hiding this comment.
I would personally rather skip these and have them passing (in order to ensure no regression) than to have them fail and ignore the failing tests going forward.
I've entered bugs to fix these failing tests, which is a better place to keep track of these issues, so I don't think we'll forget them.
…ogle-cloud-php into bigtable-conformance-tests
Hectorhammett
approved these changes
Feb 2, 2025
bshaffer
added a commit
that referenced
this pull request
Feb 11, 2025
* feat(tests): [Bigtable] add conformance tests and proxy * exclude gencode in cs * add proxy github action for testing * add workflow dispatch * install roadrunner in conformance actions * fix rr version * fix rr version (again) * add sudo * cleanup imports, use InseureCredentials * add logic for CheckAndMutateRows * fix timeout, fix numworkers * fix timeout error * fix call to checkAndMutateRow * use InsecureCredentialsWrapper * set hasEmulator to true to use http instead of https * add back insecure credentials wrapper * enable grpc in github actions * more work on the proxy * add support for ReadModifyWriteRow * add skip_tests * remove index * WIP * fixes NonTransientErrors test, moves conformance.sh * checkout to proxy v0.0.3, remove ping.php * update protos, add ExecuteQuery rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/372508972
Fixed Tests
These are tests which have been fixed by small changes to the library
TestMutateRows_NoRetry_NonTransientErrors- Fixed by adding "index" to$rowMutationsFailedResponse. See this line. This should not be a breaking change, but it is a change, so it should be confirmed.*_Generic_CloseClient- these are fixed by ensuring theappProfileIdis propagated correctly to the requests. This functionality worked in V1 but was broken in the V2 release, and is now fixed (see this line for an example)Failing Tests
TestReadRows_NoRetry_OutOfOrderErrorandTestReadRows_NoRetry_OutOfOrderError_Reverse- no error is thrown (an error should be thrown which contains "increasing" and "decreasing" in the error message, respectively). This seems to be an issue which requires fixing.TestReadRows_Retry_PausedScan,TestReadRows_Retry_StreamReset, andTestReadRows_Retry_LastScannedRow- I believe what's happening here is there is an error because the retry request doesn't contain "RowRanges" as expected. This may also be an issue which requires fixing.TestReadRows_Generic_DeadlineExceededandTestReadRow_Generic_DeadlineExceeded- failing because the deadline exceeded error is being suppressed by the retries. This seems to be WAI.TestMutateRows_Generic_DeadlineExceeded- Failing because the Deadline Exceeded exception is suppressed and added to theBigtableDataOperationException. This seems to be WAI.