dkim: compare with strings.EqualFold instead of ToLower

It doesn't allocate a new string each time. Fixes emersion#48
gowthamgts · Mar 31, 2021 · 5995b67 · 5995b67
1 parent e98a2ee
commit 5995b67
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/dkim/header.go b/dkim/header.go
@@ -149,13 +149,12 @@ func newHeaderPicker(h header) *headerPicker {
 }
 
 func (p *headerPicker) Pick(key string) string {
-	key = strings.ToLower(key)
 	at := p.picked[key]
 	for i := len(p.h) - 1; i >= 0; i-- {
 		kv := p.h[i]
 		k, _ := parseHeaderField(kv)
 
-		if strings.ToLower(k) != key {
+		if !strings.EqualFold(k, key) {
 			continue
 		}
 

diff --git a/dkim/verify.go b/dkim/verify.go
@@ -241,7 +241,7 @@ func verify(h header, r io.Reader, sigField, sigValue string, options *VerifyOpt
 	headerKeys := parseTagList(params["h"])
 	ok := false
 	for _, k := range headerKeys {
-		if strings.ToLower(k) == "from" {
+		if strings.EqualFold(k, "from") {
 			ok = true
 			break
 		}