-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add tctl plugins install
refrerence
#52878
base: master
Are you sure you want to change the base?
Conversation
Amplify deployment status
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things need to be fixed, requesting changes so we don't accidentally merge inaccurate docs.
|
||
### Flags | ||
|
||
| Name | Default Value(s) | Allowed Value(s) | Description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a column that says which flag is required and which is optional?
| `--scim-token` | none | text | The AWS Identify Center SCIM provisioning access bearer token. | | ||
| `--instance-arn` | none | ARN | The ARN of the Identity Center instance to manage | | ||
| `--instance-region` | none | text | The AWS region where the Identity Center instance is located. | | ||
| `--[no-]use-system-credentials` | `--no-use-system-credentials` | none | Use system AWS credentials to authenticate with AWS. Note that currently only `--use-system-credentials` is supported by `tctl`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that currently only
--use-system-credentials
is supported bytctl
.
This is a little confusing. Does this mean to say that "tctl" supports only use-system-creds, or that use-system-creds is only supported by tctl and not web UI currently? I assume it's the latter, in which case it feels like the word "only" should move.
| `--[no-]use-system-credentials` | `--no-use-system-credentials` | none | Use system AWS credentials to authenticate with AWS. Note that currently only `--use-system-credentials` is supported by `tctl`. | | |
| `--[no-]use-system-credentials` | `--no-use-system-credentials` | none | Use system AWS credentials to authenticate with AWS. Note that currently `--use-system-credentials` is only supported by `tctl`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, both
|
||
### Flags | ||
|
||
| Name | Default Value(s) | Allowed Value(s) | Description | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above w/r/t required vs optional arguments.
docs/pages/reference/cli/tctl.mdx
Outdated
--default-owner admin \ | ||
--default-owner [email protected] \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the table above it says this flag name is --access-list-default-owner
.
Can you please re-verify all flags are accurate?
| - | - | - | - | | ||
| `--name` | `okta` | text | Name of the plugin resource to create. | | ||
| `--org` | none | URL | URL of Okta organization. | | ||
| `--api-token` | none | text | Okta API token for the plugin to use. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API tokens for Okta integration are deprecated. We're using API service app now with OAuth 2.0 auth. Does the command support it?
cc @kopiczko
Co-authored-by: Roman Tkachenko <[email protected]>
No description provided.