Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dummy .map file to suppress "missing file" errors from some browsers. #3082

Closed
wants to merge 3 commits into from

Conversation

dabrahams
Copy link
Contributor

Especially as an inexperienced web developer, I need my presentations to function cleanly so that I get a clear indication when I've done something wrong. If I just include reveal.js in my site without a map file, I see errors in the web development pane.

@dabrahams
Copy link
Contributor Author

@hakimel Hey, I am maintaining my own fork of reveal.js, solely to deal with this problem. Is there another approach I should use? I'd like to know if you think my approach is inappropriate, in which case we should close this issue.

Thanks

P.S. I am including reveal.js in my project as a Git submodule, so I can't just go in and add the file myself without having a repository from which to pull it.

hakimel added a commit that referenced this pull request Jan 11, 2022
@hakimel
Copy link
Owner

hakimel commented Jan 11, 2022

Good catch—we shouldn't be referencing source maps that aren't available.

Instead of adding a dummy file, I've change it so the real source maps are included in the repo. I don't think that should cause any issues.

@hakimel hakimel closed this Jan 11, 2022
stefanocampanella pushed a commit to stefanocampanella/reveal.js that referenced this pull request Mar 1, 2022
srwohl pushed a commit to srwohl/phantom-pres that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants