-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
randomize completed trade info #1099
Comments
This issue has been conceptualized in collaboration between XMRfamily and monerobull 🤝 I'm not sure about the time because trade time already differs from payment time and malicious actors could observe and time initial broadcasts of trade data anyways. Probably too much work for little actual gain to add something like only reporting to arbitrator who caches the data till a specific time. |
It's been considered if any trade stats should be published at all versus operating with unknown volumes. Alternatively, maybe the trade dates and amounts could be adjusted, e.g. dates randomized within 24 hours, amounts randomized +/-5%. |
+1, you dont want a threat actor to look up haveno stats and use a specific transaction against you. for plausible deniability's sake. |
i really like looking at the haveno volume/price graph but i'd be willing to sacrifice it for the greater good 🥲 |
Trade stats are cool for marketing and advertising, but as platform grows will become more safety risk. |
Maybe keep randomized stats for a few months and then re-consider if they should be removed or not? |
a -/+5% approximation on the real volume of transactions isnt a huge problem imo, worth it for sure |
The way stats are pretty bad for privacy. But if all stats were removed then how would people know what payment methods or currencies were used by people in order to know what offers to make to improve chance of success of making a quick trade? Also stats/counts on disputes would be handy to know so people can make their own mind up if they should choose a payment method or not. Good if bugs or trader issue can be identified as the reason for dispute too. A daily summary of total trade counts, payment methods, total traded, dispute/arbitrage counts would be nice to have in future. |
This reverts commit db6cb23.
Unfortunately I needed to revert #1119, because it causes clients to re-publish the same trades over and over again, due to not recognizing previously fuzzed trades as their own. So this issue still needs a solution for this. |
like, if you trade $100 it shows anything from 95 to 105
And time wise it's randomized or daily tallied. There is some privacy/security/opsec concerns with having it easily findable. Sure bad actor could find out malicious but we should try to improve the privacy. Patterns could be established to better track traders.
Don't know if this is even possible but should be looked into
The text was updated successfully, but these errors were encountered: