[jormungandr] Use transfer pool #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 6, 2022 18:49
woshilapin
approved these changes
Dec 7, 2022
Comment on lines
+766
to
+768
| if section.type != response_pb2.TRANSFER: | ||
| continue | ||
| transfer_pool.wait_and_complete(section) |
There was a problem hiding this comment.
How about this instead?
Suggested change
| if section.type != response_pb2.TRANSFER: | |
| continue | |
| transfer_pool.wait_and_complete(section) | |
| if section.type == response_pb2.TRANSFER: | |
| transfer_pool.wait_and_complete(section) |
There was a problem hiding this comment.
it's more like a personal choice 😸 I did so coz I hate indentations in codes...
There was a problem hiding this comment.
It's one more line and the indentation is there anyway 🤷 Let's stop doing Python if indentation is a problem 😛
|
@woshilapin yep, there are a bunch of functional tests around on this feature |
pbench
reviewed
Dec 7, 2022
pbench
reviewed
Dec 7, 2022
source/jormungandr/jormungandr/scenarios/helper_classes/transfer.py
Outdated
Show resolved
Hide resolved
…er.py Co-authored-by: pbench <[email protected]>
pbench
approved these changes
Dec 7, 2022
|
Kudos, SonarCloud Quality Gate passed! |
woshilapin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
centralize all logics of transfer-computing into class
TransferPoolin order to ease the implementation of ACCESS_POINT_TRANSFER