[jormungandr] implement access_points in transfer path #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
reviewed
Dec 12, 2022
xlqian
force-pushed
the
use_access_points_in_transfer_path
branch
from
a9a512b to
74d0caa
Compare
added 2 commits
December 13, 2022 14:11
pbench
reviewed
Dec 14, 2022
source/jormungandr/jormungandr/scenarios/helper_classes/transfer.py
Outdated
Show resolved
Hide resolved
pbench
reviewed
Dec 14, 2022
pbench
reviewed
Dec 14, 2022
pbench
reviewed
Dec 14, 2022
| @@ -766,3 +777,34 @@ def complete_transfer(pt_journey, transfer_pool): | |||
| if section.type != response_pb2.TRANSFER: | |||
| continue | |||
| transfer_pool.wait_and_complete(section) | |||
|
|
|||
|
|
|||
| def prepend_first_and_append_last_coord(dp, origin, destination): | |||
There was a problem hiding this comment.
Maybe split this function in two prepend_first_coord() and append_last_coord() ?
There was a problem hiding this comment.
And don't you already have the exact same function here ?
pbench
reviewed
Dec 14, 2022
Comment on lines
789
to
791
| nb_coords = sum((len(sec.street_network.coordinates) for sec in dp.journeys[0].sections)) | ||
| if nb_coords < 2: | ||
| return |
There was a problem hiding this comment.
I don't really understand this check. Maybe add some comments ?
There was a problem hiding this comment.
it just checks the length of the geojson of the street network, there should be at least 2 points in a geojson logically
added 2 commits
December 14, 2022 18:12
pbench
approved these changes
Dec 15, 2022
|
Kudos, SonarCloud Quality Gate passed! |
woshilapin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR. transfer paths are allowed between surface transport vehicles (
tramway,busetc...) and underground transport vehicles (metroetc...) via access points.Note that :
How the access point (if multiple access points are present for the underlying stop point) is picked in a nutshell:
Let's say we need to calculate the path from
stop_point:Tramwaytostop_point: Metro, given thatstop_point: Metrohas 3 access points around it. The first step is to choose the eligible access points by requesting thegeorefall the access points ofstop_point:Metroand filtering out those areis_entrance == False. Then we compute a matrix of1xN(reciprocallyNx1when transferring fromstop_point:Metrotostop_point:Tramway). By adding up thetraversal_timeof each access points to the street network duration, we pick the most rapid access point to get tostop_point:Metro. Then we launch the real street network computation betweenstop_point:Tramwayand the chosen access point.In the following example, the blue line (underground transport) has multiple access points,
but we finally chose the best/most rapid access point to get to the platform
