[jormungandr] fix zmq socket lifetime #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azime
approved these changes
Dec 9, 2022
pbench
reviewed
Dec 9, 2022
xlqian
force-pushed
the
fix_socket_lifetime
branch
from
41c25be to
ad71061
Compare
xlqian
force-pushed
the
fix_socket_lifetime
branch
from
ad71061 to
6dc0413
Compare
pbench
approved these changes
Dec 9, 2022
|
Kudos, SonarCloud Quality Gate passed! |
woshilapin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the lifetime of the zmq socket was based on the time of the last successful request, which extends its lifetime in practice.
In this PR, zmq socket lifetime will be based on its spawn time, which means once the TTL is out, zmq socket will be closed and removed from the socket pool.