Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New docker worflow #3895

Merged
merged 10 commits into from
Jan 6, 2023
Merged

New docker worflow #3895

merged 10 commits into from
Jan 6, 2023

Conversation

pbench
Copy link
Contributor

@pbench pbench commented Jan 5, 2023

New worflow that :

  • create navitia packages
  • build the dockers from the navitia packages (I imported the contents of hove-io/navitia-docker-compose)
  • push the images on dockerhub
  • trigger the push of the images on aws

woshilapin
woshilapin approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say we don't need all the Debian 10 stuff since we have problem with it. How about not keeping it here?

@pbench
Copy link
Contributor Author

pbench commented Jan 6, 2023

I'd say we don't need all the Debian 10 stuff since we have problem with it. How about not keeping it here?

I think (?) these are also useful for debian11 (which want to switch to). Maybe @xlqian can confirm ?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pbench
Copy link
Contributor Author

pbench commented Jan 6, 2023

I merge this PR to test if everything works.
I'll do a subsequent PR to clean things up.

@pbench pbench merged commit 453aebf into dev Jan 6, 2023
@pbench pbench deleted the modify_release branch January 6, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@azime azime Awaiting requested review from azime

@kadhikari kadhikari Awaiting requested review from kadhikari

@pbougue pbougue Awaiting requested review from pbougue

@xlqian xlqian Awaiting requested review from xlqian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbench @woshilapin