Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kraken: Fix disruption's channel type list in a channel #3897

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Kraken: Fix disruption's channel type list in a channel #3897

merged 1 commit into from
Jan 11, 2023

Conversation

kadhikari
Copy link
Contributor

@kadhikari kadhikari commented Jan 6, 2023 •
edited
Loading

Note: Tested using fr-nw-tours data from CUS and chaos_cus with @Msaglier

In chaos:

channel1:

  • channel_type1 (web)
  • channel_type2 (mobile)

Channel2:

  • channel_type3 (title)

Before correction In navitia:

channel1:

  • channel_type1 (web)
  • channel_type2 (mobile)

Channel2:

  • channel_type1 (web)
  • channel_type2 (mobile)
  • channel_type3 (title)

After correction in navitia:

channel1:

  • channel_type1 (web)
  • channel_type2 (mobile)

Channel2:

  • channel_type3 (title)

For more details: https://navitia.atlassian.net/browse/NAV-1688

@woshilapin woshilapin removed their request for review January 6, 2023 13:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

59.4% 59.4% Coverage
0.0% 0.0% Duplication

@kadhikari kadhikari merged commit df43455 into dev Jan 11, 2023
@kadhikari kadhikari deleted the fix_channel_types_in_a_channel branch January 11, 2023 09:28
@pbougue pbougue changed the title Fix channel type list in a channel Kraken: Fix disruption's channel type list in a channel Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azime azime azime approved these changes

@xlqian xlqian xlqian approved these changes

@SGrenet SGrenet SGrenet approved these changes

@Msaglier Msaglier Msaglier approved these changes

@pbench pbench pbench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kadhikari @azime @xlqian @SGrenet @Msaglier @pbench