Remove old release script and workflows #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
azime
approved these changes
Jan 13, 2023
xlqian
approved these changes
Jan 18, 2023
pbougue
approved these changes
Jan 23, 2023
pbougue
reviewed
Jan 23, 2023
readme_release.md
Outdated
Comment on lines
1
to
18
| # HOW TO Release navitia | ||
|
|
||
| ## Versioning | ||
|
|
||
| Our versionning is based on [Semantic Versionning](nhttps://semver.org/) | ||
| * the **major** version is bumped in case of an API/interface change or **when a binarisation is needed**. | ||
| * the **minor** version is bumped when functionnalities are backward compatible. | ||
| * the **patch** version is bumped on a bug fix. | ||
|
|
||
| ## "Regular" release | ||
|
|
||
| This lets the script decide if it's major or minor release. | ||
| The decision is based on the data_version located in source/type/data.cpp | ||
| See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how data_version is managed. | ||
|
|
||
| First have a look on github's repo at PRs about to be released https://github.com/hove-io/navitia/pulls?q=is%3Apr+is%3Aclosed+sort%3Aupdated-desc | ||
| * Check that `not_in_changelog` and `hotfix` labels are correct and none is missing on PRs that are gonna be released | ||
| * Check that titles are correct (clear, with the component impacted) |
There was a problem hiding this comment.
On second thought, I think we should keep it (almost) and just mention in the end that it's done on Github, not by script anymore.
I'm OK to do a PR on this if it's OK with you.
If not, it should be removed from
Line 71 in ea3dea7
There was a problem hiding this comment.
Done in f71f5d5
IMO, we can now merge.
Not planning any additional work on the subject.
pbougue
force-pushed
the
clean_workflows
branch
from
d7710a4 to
f71f5d5
Compare
Also minor typo change
pbougue
force-pushed
the
clean_workflows
branch
from
f71f5d5 to
f7a75ce
Compare
|
looks good to me 👍 |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge after running the new workflow for a few days/weeks