[Kraken] fix erase vj from dataset #3910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbougue
reviewed
Jan 13, 2023
xlqian
force-pushed
the
fix_erase_vj_from_dataset
branch
from
25917c3 to
712d85d
Compare
xlqian
force-pushed
the
fix_erase_vj_from_dataset
branch
from
712d85d to
118c2d3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
pbougue
approved these changes
Feb 8, 2023
Comment on lines
+415
to
+416
| if (!pt_data.datasets.empty()) { | ||
| if (pt_data.datasets[0]) { |
There was a problem hiding this comment.
Looks like you're checking almost twice the same thing, but if you want to keep double check it's probably more expressive like:
Suggested change
| if (!pt_data.datasets.empty()) { | |
| if (pt_data.datasets[0]) { | |
| if (!pt_data.datasets.empty() && pt_data.datasets[0] != nullptr) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix "impossible to find the vj" when erasing vj from dataset