Init Handimap connector #3911
Init Handimap connector #3911
Conversation
| @@ -495,6 +495,20 @@ def __init__(self): | |||
| hidden=True, | |||
| help="Here, Active or not the realtime traffic information (True/False)", | |||
| ) | |||
| parser_get.add_argument( | |||
There was a problem hiding this comment.
I think we should stop adding parameters _*_language every time we add a new connector...
let's refactorise that later...
| ): | ||
| if mode != "walking": | ||
| logging.getLogger(__name__).error('Handimap, mode {} not implemented'.format(mode)) | ||
| raise InvalidArguments('Handimap, mode {} not implemented'.format(mode)) |
There was a problem hiding this comment.
👍
can also check this in the constructor plz?
| self.auth = (username, password) | ||
| self.headers = {"Content-Type": "application/json", "Accept": "application/json"} | ||
| self.timeout = timeout | ||
| self.modes = modes |
There was a problem hiding this comment.
can you check if walking is the only mode defined? and raise and exception if it's not the case
| @@ -0,0 +1,336 @@ | |||
| # Copyright (c) 2001-2022, Hove and/or its affiliates. All rights reserved. | |||
There was a problem hiding this comment.
| # Copyright (c) 2001-2022, Hove and/or its affiliates. All rights reserved. | |
| # Copyright (c) 2001-2023, Hove and/or its affiliates. All rights reserved. |
| try: | ||
| return Languages[language].value | ||
| except KeyError: | ||
| self.log.error('Handimap parameters language={} not exist - force to french'.format(language)) |
There was a problem hiding this comment.
| self.log.error('Handimap parameters language={} not exist - force to french'.format(language)) | |
| self.log.error('Handimap parameter language={} is not a valid parameter - language is set to french by default'.format(language)) |
There was a problem hiding this comment.
why is the default value french?
| post_data, | ||
| ) | ||
| self.check_response(response) | ||
| return ujson.loads(response.text) |
There was a problem hiding this comment.
i would recommend you to add a try-catch around ujson.loads in case of non utf-8 characters...
|
|
||
| origin = make_pt_object(type_pb2.ADDRESS, lon=-1.6761174, lat=48.1002462, uri='HandimapStart') | ||
| destination = make_pt_object(type_pb2.ADDRESS, lon=-1.6740057, lat=48.097592, uri='HandimapEnd') | ||
| fallback_extremity = PeriodExtremity(str_to_time_stamp('20220503T060000'), True) |
There was a problem hiding this comment.
can you test with PeriodExtremity(str_to_time_stamp('20220503T060000'), False) plz
| if index == len(handimap_trip['legs']) - 1: | ||
| section.destination.CopyFrom(pt_object_destination) | ||
|
|
||
| section.street_network.duration = section.duration |
| section.id = 'section_{}'.format(index) | ||
| section.length = int(round(kilometers_to_meters(handimap_leg["summary"]['length']))) | ||
|
|
||
| if index == 0: |
There was a problem hiding this comment.
to avoid branches (if), you can do operations to the specific items at the end..
| section.street_network.duration = section.duration | ||
| section.street_network.length = section.length | ||
| section.street_network.mode = response_pb2.Walking |
There was a problem hiding this comment.
| section.street_network.duration = section.duration | |
| section.street_network.length = section.length | |
| section.street_network.mode = response_pb2.Walking | |
| section.street_network.duration = section.duration | |
| section.street_network.length = section.length | |
| section.street_network.mode = response_pb2.Walking |
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.