Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The ghost word matchings should be case insensitive #3912

Merged
merged 2 commits into from
Jan 26, 2023
Merged

The ghost word matchings should be case insensitive #3912

merged 2 commits into from
Jan 26, 2023

Conversation

kadhikari
Copy link
Contributor

While deleting ghost words from query string it should be case insensitive.

For more details: https://navitia.atlassian.net/browse/NAV-1629

pbougue
pbougue approved these changes Jan 19, 2023
View reviewed changes
@kadhikari kadhikari requested a review from pbougue January 19, 2023 13:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kadhikari kadhikari merged commit c4b704f into dev Jan 26, 2023
@kadhikari kadhikari deleted the fix_delete_ghost_words_in_the_query branch January 26, 2023 16:21
@wassimbenaissa
Copy link
Contributor

Super nice, thanks @kadhikari :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlqian xlqian xlqian approved these changes

@pbougue pbougue pbougue approved these changes

@azime azime Awaiting requested review from azime

@pbench pbench Awaiting requested review from pbench

@wassimbenaissa wassimbenaissa Awaiting requested review from wassimbenaissa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadhikari @wassimbenaissa @xlqian @pbougue