Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[Jormungandr] Use transient socket for instance, pt planner and asgard, AND remove socket reaper" #3914

Closed
wants to merge 2 commits into from
Closed

Revert "[Jormungandr] Use transient socket for instance, pt planner and asgard, AND remove socket reaper" #3914

wants to merge 2 commits into from

Conversation

pbougue
Copy link
Contributor

@pbougue pbougue commented Jan 20, 2023

Reverts #3883

Just in case.

@pbougue pbougue requested review from azime and xlqian January 20, 2023 17:32
@pbougue pbougue force-pushed the revert-3883-use_transient_socket_for_all_and_remove_socket_reaper branch from 70f8918 to 8cc146b Compare January 21, 2023 12:21
@pbougue
Copy link
Contributor Author

pbougue commented Jan 21, 2023

Rebased onto v15.26.0 to avoid embedding any other PR merged since.

@xlqian xlqian force-pushed the revert-3883-use_transient_socket_for_all_and_remove_socket_reaper branch from 40ebe6e to a3fcea8 Compare January 25, 2023 23:20
@xlqian
Copy link
Member

xlqian commented Jan 25, 2023 •
edited
Loading

Rebased onto v15.26.3, pre-release created v15.26.5.

@xlqian xlqian force-pushed the revert-3883-use_transient_socket_for_all_and_remove_socket_reaper branch from 9da89cb to 7188690 Compare January 26, 2023 15:38
@xlqian
Copy link
Member

xlqian commented Jan 26, 2023

Release v15.26.4

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

71.1% 71.1% Coverage
0.0% 0.0% Duplication

@pbougue
Copy link
Contributor Author

pbougue commented Feb 6, 2023

After some tests and use without reverting, this revert should not be necessary, ever.

@pbougue pbougue closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlqian xlqian xlqian approved these changes

@azime azime Awaiting requested review from azime

Assignees
No one assigned
Labels
do_not_merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbougue @xlqian