Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize while fetching authorized coverages for an user #3916

Merged
merged 7 commits into from
Jan 24, 2023
Merged

Optimize while fetching authorized coverages for an user #3916

merged 7 commits into from
Jan 24, 2023

Conversation

kadhikari
Copy link
Contributor

@kadhikari kadhikari commented Jan 24, 2023 •
edited by pbougue
Loading

Fetching list of coverage for a request without coverage:
Before:

  • Fetch all the coverages where from and to objects could be found. This function requires verifying existence of coord/pt_object in each coverage (all coverages) even if cached.
  • Filter authorized coverages for the user among coverages found above.

After:

  • For an user, get list of authorized coverages (free + private)
  • Filter coverages for coord/objects in the request without coverage

Note: The work is not finished yet. There are some test fails.

@kadhikari kadhikari requested review from pbougue and azime January 24, 2023 10:15
kadhikari
kadhikari commented Jan 24, 2023
View reviewed changes
Copy link
Contributor Author

@kadhikari kadhikari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifications by @xlqian are fine to me
Thanks

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

89.2% 89.2% Coverage
0.0% 0.0% Duplication

@xlqian xlqian merged commit 762cf9d into dev Jan 24, 2023
@xlqian xlqian deleted the optimize_verif_instance_for_user branch January 24, 2023 19:56
@kadhikari kadhikari mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlqian xlqian xlqian approved these changes

@azime azime azime approved these changes

@pbench pbench pbench approved these changes

@stifoon stifoon Awaiting requested review from stifoon

@pbougue pbougue Awaiting requested review from pbougue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadhikari @azime @xlqian @pbench