Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify type in user before comparison #3924

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Verify type in user before comparison #3924

merged 1 commit into from
Feb 1, 2023

Conversation

kadhikari
Copy link
Contributor

It's rare that g.user is None but i found some occurrence in log so better verify existence of attribute type.

Note: No need to verify g.user is not None

@woshilapin woshilapin changed the title Verify type in user before comparision Verify type in user before comparison Jan 30, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@azime azime merged commit 19e5ff9 into dev Feb 1, 2023
@azime azime deleted the fix_verify_user_type_no_access branch February 1, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@xlqian xlqian xlqian approved these changes

@pbench pbench Awaiting requested review from pbench

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadhikari @woshilapin @xlqian @azime