Replace _get_authorized_instances #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woshilapin
approved these changes
Jan 31, 2023
| @@ -297,7 +298,7 @@ def get_instances(self, name=None, lon=None, lat=None, object_id=None, api='ALL' | |||
| else: | |||
| # Requests without any coverage | |||
| # fetch all the authorized instances (free + private) using cached function has_access() | |||
| authorized_instances = self._get_authorized_instances(user, api) | |||
| authorized_instances = get_all_available_instances(user) # self._get_authorized_instances(user, api) | |||
There was a problem hiding this comment.
I believe you can remove the comment. git history is enough to remember.
kadhikari
requested changes
Feb 2, 2023
| @@ -341,3 +342,24 @@ def regions(self, region=None, lon=None, lat=None, request_id=None): | |||
| resp_dict['region_id'] = key_region | |||
| response['regions'].append(resp_dict) | |||
| return response | |||
|
|
|||
| def get_all_available_instances(self, user): | |||
There was a problem hiding this comment.
This function should be cached.
As discussed with @pbench if we can remove the condition as described in
we can re-user the function authentification.get_all_available_instances or add a simplified and cached function only to be used for this purpose.
kadhikari
approved these changes
Feb 2, 2023
|
Kudos, SonarCloud Quality Gate passed! |
xlqian
approved these changes
Feb 7, 2023
| else: | ||
| return result | ||
|
|
||
| bdd_instances = user.get_all_available_instances() |
There was a problem hiding this comment.
Suggested change
| bdd_instances = user.get_all_available_instances() | |
| instances_from_db = user.get_all_available_instances() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover instances authorized for a user with a single database call, instead of one database call for each configured instance