Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_without_access func #3929

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Remove get_without_access func #3929

merged 2 commits into from
Feb 7, 2023

Conversation

azime
Copy link
Contributor

@azime azime commented Feb 2, 2023

This correction prevents access to the database for an unknown token:

  • Before: One access to database to verify + another access to the database to get user of type no_access during de cache period.
  • After: One access to database to verify but no more access during de cache period.

Note: This correction is more useful when someone attacks navitia with a script using a new token each time.

https://navitia.atlassian.net/browse/NAV-1779

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@azime azime merged commit 8b51cef into dev Feb 7, 2023
@azime azime deleted the remove_get_without_access branch February 7, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants