Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling the database in case of exception for a period configured #3941

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

kadhikari
Copy link
Contributor

@kadhikari kadhikari commented Feb 20, 2023

If There is an exception while sending a query to the database, we should update last_update time to NOW so that no query is send to the data base for another update_interval as configured.

This correction avoids access to the data for each service as street_network, external_service as well as bss_provide for a period of update_interval as configured.

There are some minor modifications to reduce possible error.

Relates to: https://navitia.atlassian.net/browse/NAV-1819

@kadhikari kadhikari requested a review from pbougue February 21, 2023 08:12
Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a sensitive word recently, but... Should we put a circuit breaker?

@kadhikari kadhikari requested a review from pbench February 21, 2023 15:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

21.4% 21.4% Coverage
0.0% 0.0% Duplication

@kadhikari kadhikari merged commit 3510cd5 into dev Feb 22, 2023
@kadhikari kadhikari deleted the fix_external_sevice_last_update_if_error branch February 22, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants