Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crowfly_air_pollutants if error occurs before #3946

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Fix crowfly_air_pollutants if error occurs before #3946

merged 1 commit into from
Mar 1, 2023

Conversation

kadhikari
Copy link
Contributor

  • If error occurs before calculating crowfly_air_pollutants, origin and/or destination are not correct.
  • With this correction, the function will return None and hence will not be in error.

For more details: https://navitia.atlassian.net/browse/NAV-1760

Note: The error was found in navitia sbx

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@azime azime merged commit 9382a75 into dev Mar 1, 2023
@azime azime deleted the fix_get_crowfly_air_pollutants branch March 1, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azime azime azime approved these changes

@xlqian xlqian xlqian approved these changes

@pbench pbench pbench approved these changes

@pbougue pbougue Awaiting requested review from pbougue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadhikari @azime @xlqian @pbench