Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade flask caching #3947

Merged
merged 16 commits into from
Mar 8, 2023
Merged

Downgrade flask caching #3947

merged 16 commits into from
Mar 8, 2023

Conversation

azime
Copy link
Contributor

@azime azime commented Mar 3, 2023

No description provided.

@pbougue pbougue changed the title Downgrad falsk caching Downgrad flask caching Mar 3, 2023
@pbougue pbougue changed the title Downgrad flask caching Downgrade flask caching Mar 3, 2023
@azime azime requested review from kadhikari and pbench March 7, 2023 15:12
@@ -66,6 +67,8 @@ def __repr__(self):
"""
used as the cache key. we use the rt_system_id to share the cache between servers in production
"""
if PY3:
self.rt_system_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
self.rt_system_id
return self.rt_system_id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

63.4% 63.4% Coverage
0.0% 0.0% Duplication

@azime azime merged commit 45bbb5a into dev Mar 8, 2023
@azime azime deleted the downgrad_falsk_caching branch March 8, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants