Jormun: Optim log readyness and others #3950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
pbench
reviewed
Mar 9, 2023
pbougue
reviewed
Mar 9, 2023
Comment on lines
-78
to
-79
| if '.' not in cls: | ||
| self.logger.warning('impossible to build, wrongly formated class: {}'.format(cls)) |
There was a problem hiding this comment.
I don't get what's affected by that change, even though it looks harmless.
There was a problem hiding this comment.
It is most probable that there will be an exception and hence will write another log four lines after.
I simply deleted duplicate log writing.
There was a problem hiding this comment.
I think the change is that if we use a "root" class it won't raise anymore, but before it did... I guess it's not important.
pbench
approved these changes
Mar 9, 2023
pbougue
approved these changes
Mar 9, 2023
azime
approved these changes
Mar 13, 2023
pbougue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details: https://navitia.atlassian.net/browse/NAV-1858