Kraken: only process the last RT message of a batch for a given entity.id #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y.id As documented, this is possible to save some processing for both chaos and kirin. See: https://github.com/hove-io/chaos-proto/blob/ab4a1265f933a98bf0efee65f498a331a260b3b4/chaos_proto_doc.rs#L37-L39 and https://github.com/hove-io/chaos-proto/blob/ab4a1265f933a98bf0efee65f498a331a260b3b4/kirin_proto_doc.rs#L37-L39 Inspired by #3909 (comment) temporarily reverted in 6bfc01c#diff-e3c74159dd251840eba27db267ef32654abe662d6a1333da9a7878dbf866a338 JIRA: https://navitia.atlassian.net/browse/NAV-1878
woshilapin
approved these changes
Mar 29, 2023
pbench
approved these changes
Mar 29, 2023
|
Kudos, SonarCloud Quality Gate passed! |
xlqian
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented, this is possible to save some processing for both chaos and kirin.
See: https://github.com/hove-io/chaos-proto/blob/ab4a1265f933a98bf0efee65f498a331a260b3b4/chaos_proto_doc.rs#L37-L39 and https://github.com/hove-io/chaos-proto/blob/ab4a1265f933a98bf0efee65f498a331a260b3b4/kirin_proto_doc.rs#L37-L39
Inspired by #3909 (comment) temporarily reverted in 6bfc01c#diff-e3c74159dd251840eba27db267ef32654abe662d6a1333da9a7878dbf866a338
JIRA: https://navitia.atlassian.net/browse/NAV-1878