Jormungandr: Cache Co2 emission value instead of pb object

[kadhikari]

Two problems occurred while caching pb object Co2Emission

• Caching for key = uri, request_id: as request_id is unique for a request global to navitia, caching on uri and request_id is useless.
• Caching pb object raises error (see ticket for more details)

A little adjustment is made to pass request_id without including it's value as key while caching.

For more details: https://navitia.atlassian.net/browse/NAV-1667

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

83.3% Coverage
0.0% Duplication

[woshilapin]

I believe this can be fixed differently in a much simpler way.

[woshilapin]

Instead of using this convoluted solution of an inner function, to ignore the request_id from the cache key, @cache.memoize has an option to ignore some function parameters with args_to_ignore (see documentation).

So the PR could only be

        @memory_cache.memoize(
            current_app.config[str('MEMORY_CACHE_CONFIGURATION')].get(str('TIMEOUT_AUTHENTICATION'), 30),
            args_to_ignore=["request_id"],
        )
        @cache.memoize(
            current_app.config[str('CACHE_CONFIGURATION')].get(str('TIMEOUT_AUTHENTICATION'), 300), 
            args_to_ignore=["request_id"],
        )

[woshilapin]

I'm not sure that the if co2_emission > 0 else 0 is useful. In case co2_emission == 0, the calculation will already be 0. Can co2_emission be negative?

[kadhikari]

This will avoid negative value