[Jormungandr] Fix LEZ when fallbacks are car #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbench
reviewed
Apr 6, 2023
source/jormungandr/jormungandr/scenarios/helper_classes/complete_pt_journey.py
Show resolved
Hide resolved
pbench
reviewed
Apr 6, 2023
Comment on lines
+117
to
+132
| tmp_list = [ | ||
| not section.low_emission_zone.on_path | ||
| for section in journey.sections | ||
| if section.HasField('low_emission_zone') | ||
| ] | ||
| # all([]) == True it's not what we want :( | ||
| if tmp_list and all(tmp_list): | ||
| journey.low_emission_zone.on_path = False | ||
| elif any( | ||
| section.low_emission_zone.on_path | ||
| for section in journey.sections | ||
| if section.HasField('low_emission_zone') | ||
| ): | ||
| journey.low_emission_zone.on_path = True | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| tmp_list = [ | |
| not section.low_emission_zone.on_path | |
| for section in journey.sections | |
| if section.HasField('low_emission_zone') | |
| ] | |
| # all([]) == True it's not what we want :( | |
| if tmp_list and all(tmp_list): | |
| journey.low_emission_zone.on_path = False | |
| elif any( | |
| section.low_emission_zone.on_path | |
| for section in journey.sections | |
| if section.HasField('low_emission_zone') | |
| ): | |
| journey.low_emission_zone.on_path = True | |
| for section in journey.sections: | |
| if section.HasField('low_emission_zone'): | |
| if section.low_emission_zone.on_path: | |
| journey.low_emission_zone.on_path = True | |
| break |
There was a problem hiding this comment.
it won't work if none of the fallbacks has LEZ...
There was a problem hiding this comment.
and for the sake of compatibility, we don't display low_emission_zone.on_path if the information of LEZ is unavailable...
pbench
approved these changes
Apr 6, 2023
azime
approved these changes
Apr 6, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, two cases are fixed:
at least one of the fallbacks traverses LEZ, we set
on_pathto true for the whole journey :none of the fallbacks traverses LEZ, we set
on_pathto false for the whole journey: