Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kraken: fix typo in broker param name #3973

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Kraken: fix typo in broker param name #3973

merged 2 commits into from
Apr 18, 2023

Conversation

pbench
Copy link
Contributor

@pbench pbench commented Apr 11, 2023 •
edited by pbougue
Loading

After #3968

@pbench pbench requested review from azime and pbougue April 11, 2023 14:38
pbougue
pbougue approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 🙏

pbougue
pbougue approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial self-approval:

  • I rebased to have it directly on v15.30.0
  • I added a commit to have naming consistent

@pbougue pbougue changed the title fix typo in broker param name Kraken: fix typo in broker param name Apr 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

38.1% 38.1% Coverage
0.0% 0.0% Duplication

@pbougue pbougue merged commit 88fb0c1 into dev Apr 18, 2023
@pbougue pbougue deleted the fix_typo branch April 18, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azime azime azime approved these changes

@xlqian xlqian xlqian approved these changes

@pbougue pbougue pbougue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pbench @azime @xlqian @pbougue