Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix portable min #3980

Merged
merged 4 commits into from
Apr 20, 2023
Merged

fix portable min #3980

merged 4 commits into from
Apr 20, 2023

Conversation

pbench
Copy link
Contributor

@pbench pbench commented Apr 20, 2023 •
edited by pbougue
Loading

Default keyword arg must be provided in python 3.9, otherwise a ValueError is raised, and that happen

JIRA: https://navitia.atlassian.net/browse/NAV-1971

pbougue
pbougue approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

pbougue
pbougue approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@pbougue pbougue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for tests

@pbench pbench merged commit 9c86460 into dev Apr 20, 2023
@pbench pbench deleted the fix_portable_min branch April 20, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azime azime azime approved these changes

@pbougue pbougue pbougue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbench @azime @pbougue