Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jormun: INIT - Manage best boarding positions #3981

Merged
merged 20 commits into from
Apr 25, 2023
Merged

Jormun: INIT - Manage best boarding positions #3981

merged 20 commits into from
Apr 25, 2023

Conversation

kadhikari
Copy link
Contributor

@kadhikari kadhikari commented Apr 20, 2023 •
edited
Loading

  • Get best_boarding_positions directory from the config: BEST_BOARDING_POSITIONS_DIR
  • Load a file with name = .csv if exists in the directory and associate to the instance: instance.best_boarding_positions = [..]
  • Update all the PT sections before transfer or (street_network and with vias) with best boarding positions if best_boarding_positions exist for this instance(coverage).
  • Some unit tests added

For details: https://navitia.atlassian.net/browse/NAV-1932

@kadhikari kadhikari requested review from xlqian, azime and pbench April 20, 2023 15:22
xlqian
xlqian reviewed Apr 21, 2023
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

79.2% 79.2% Coverage
0.0% 0.0% Duplication

@xlqian xlqian merged commit c21b469 into dev Apr 25, 2023
@xlqian xlqian deleted the feat_best_boarding_positions branch April 25, 2023 12:00
@pbougue pbougue changed the title INIT: Manage best boarding positions Jormun: INIT - Manage best boarding positions Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlqian xlqian xlqian left review comments

@azime azime azime approved these changes

@pbench pbench pbench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kadhikari @azime @xlqian @pbench